Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow multiple connections in Solara #1759

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Aug 7, 2023

No description provided.

@rht
Copy link
Contributor Author

rht commented Aug 7, 2023

This PR addresses #856, but only for Solara viz.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (1ea0dc7) 80.66% compared to head (2fcfc1d) 80.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1759      +/-   ##
==========================================
+ Coverage   80.66%   80.68%   +0.02%     
==========================================
  Files          15       15              
  Lines         869      870       +1     
  Branches      183      184       +1     
==========================================
+ Hits          701      702       +1     
  Misses        147      147              
  Partials       21       21              
Files Changed Coverage Δ
mesa/experimental/jupyter_viz.py 19.35% <100.00%> (+0.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 0bb908d into projectmesa:main Aug 10, 2023
13 checks passed
@rht rht deleted the solara_multiple_connections branch August 10, 2023 10:02
@tpike3 tpike3 added this to the Release 2.1.2 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants