Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure playing starts when clicked after model param change #1851

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: Ensure playing starts when clicked after model param change #1851

merged 1 commit into from
Nov 3, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Oct 30, 2023

Fixes: #1845

@rht rht mentioned this pull request Oct 30, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4ec7433) 77.42% compared to head (e819f30) 77.10%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1851      +/-   ##
==========================================
- Coverage   77.42%   77.10%   -0.32%     
==========================================
  Files          15       15              
  Lines         970      974       +4     
  Branches      213      214       +1     
==========================================
  Hits          751      751              
- Misses        191      195       +4     
  Partials       28       28
Files Coverage Δ
mesa/experimental/jupyter_viz.py 34.03% <0.00%> (-0.59%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tpike3
tpike3 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 0f196e5 into projectmesa:main Nov 3, 2023
13 of 15 checks passed
@rht rht deleted the fix-play branch November 3, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpike3 tpike3 tpike3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JupyterViz: after changing parameters, play button does not work
2 participants
@rht @tpike3