Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life: automatically fix ruff errors #2004

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Corvince
Copy link
Contributor

Two small changes that should make it easier to contribute.

  1. Run ruff pre-commit with the fix argument - I can't think why this shouldn't be desirable. Otherwise you just have to fix errors manually. Thanks @Aryan1Mahahjan for the inspiration
  2. Run pre-commit.ci automatically. This makes it much easier for new contributors to not fail on formatting errors. The downside is that this might introduce an additional commit, but they are easy to spot and ignore while looking in the git history (there is no worry that features were changed in contrast to a commit that was just named "fix lint" manually)

@rht
Copy link
Contributor

rht commented Jan 25, 2024

Run ruff pre-commit with the fix argument - I can't think why this shouldn't be desirable. Otherwise you just have to fix errors manually. Thanks @Aryan1Mahahjan for the inspiration

SGTM

Run pre-commit.ci automatically. This makes it much easier for new contributors to not fail on formatting errors.

SGTM, this is also helpful for existing contributors so as not to skip auto-fixable pre-commit errors.

@rht rht merged commit 99b35fc into projectmesa:main Jan 25, 2024
13 checks passed
@EwoutH
Copy link
Contributor

EwoutH commented Jan 25, 2024

Fully agree, I did propose this a few months ago. Glad to see it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants