Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterViz: {Convert make_plot & prepare ColorCard} to become Solara component #2020

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 30, 2024

No description provided.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 -0.1% [-0.4%, +0.1%] 🔵 -0.3% [-0.5%, -0.2%]
Schelling large 🔵 -1.4% [-3.2%, +0.0%] 🔵 -3.4% [-5.2%, -1.5%]
WolfSheep small 🔵 +0.9% [+0.6%, +1.1%] 🔵 +1.6% [+1.5%, +1.8%]
WolfSheep large 🔵 -0.1% [-0.6%, +0.5%] 🔵 +0.1% [-0.4%, +0.5%]
BoidFlockers small 🔵 +0.9% [+0.4%, +1.6%] 🔵 +0.6% [-0.2%, +1.3%]
BoidFlockers large 🔵 +1.3% [+0.9%, +1.6%] 🔵 +0.5% [-0.1%, +1.2%]

@rht rht changed the title JupyterViz: Convert make_plot to Solara component; prepare ColorCard to become Solara component JupyterViz: Convert make_plot & prepare ColorCard to become Solara component Jan 30, 2024
@rht rht changed the title JupyterViz: Convert make_plot & prepare ColorCard to become Solara component JupyterViz: {Convert make_plot & prepare ColorCard} to become Solara component Jan 31, 2024
@rht
Copy link
Contributor Author

rht commented Feb 5, 2024

@projectmesa/maintainers I request for a review. This is way too long overdue for such a simple refactor PR.

@jackiekazil
Copy link
Member

I looked this through. LGTM.... wanted to ask -- are there are examples to test it with?

@rht
Copy link
Contributor Author

rht commented Feb 5, 2024

There are at least 2 examples:

  1. https://github.com/projectmesa/mesa-examples/tree/main/examples/boltzmann_wealth_model_experimental
  2. https://github.com/projectmesa/mesa-examples/tree/main/examples/schelling_experimental

More at: boid flockers, Game of Life, Sugarscape G1MT, and virus on network.

@jackiekazil
Copy link
Member

Ty! That is what I thought, but wanted to confirm. All looks good.

@jackiekazil jackiekazil merged commit b2e1446 into projectmesa:main Feb 5, 2024
14 checks passed
@rht rht deleted the jv branch February 5, 2024 05:16
@jackiekazil jackiekazil added the enhancement Release notes label label Feb 5, 2024
@jackiekazil jackiekazil added this to the Unknown milestone milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants