Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct wolf energy gained from eating sheep #2048

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

JackAtOmenApps
Copy link
Contributor

Implementing the already existing class attribute that was correctly used in Sheep, but not in Wolf.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 +1.3% [+1.2%, +1.5%] 🔵 -0.0% [-0.2%, +0.1%]
Schelling large 🔵 +11.4% [-12.9%, +51.6%] 🔵 -0.4% [-0.8%, +0.0%]
WolfSheep small 🔵 +1.0% [+0.7%, +1.3%] 🔵 +1.8% [+0.5%, +3.0%]
WolfSheep large 🔴 +24.1% [+6.5%, +47.2%] 🔵 +2.4% [+0.7%, +3.9%]
BoidFlockers small 🔵 +0.5% [-0.0%, +1.1%] 🔵 -0.3% [-1.1%, +0.4%]
BoidFlockers large 🔵 +1.2% [+0.9%, +1.6%] 🔵 -1.0% [-1.4%, -0.5%]

@rht rht merged commit 0d01a53 into projectmesa:main Feb 22, 2024
13 checks passed
@rht
Copy link
Contributor

rht commented Feb 22, 2024

Merged, thank you.

@EwoutH
Copy link
Contributor

EwoutH commented Feb 22, 2024

Good catch, thanks!

quaquel pushed a commit to quaquel/mesa that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants