Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JupyterViz Altair marker overlap for huge grid size #2062

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Feb 29, 2024

This is #2049, but for the Altair visualization instead.
20x20
20x20
60x60
60x60
100x100
100x100

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 -0.5% [-0.8%, -0.2%] 🔵 -0.1% [-0.3%, +0.0%]
Schelling large 🔵 +0.2% [-0.3%, +0.6%] 🔵 +0.2% [-0.7%, +1.2%]
WolfSheep small 🔵 -0.4% [-0.6%, -0.2%] 🔵 -0.1% [-0.2%, +0.0%]
WolfSheep large 🔵 +0.8% [+0.0%, +1.7%] 🔵 +1.8% [+0.8%, +2.7%]
BoidFlockers small 🔵 -0.9% [-1.4%, -0.4%] 🔵 +1.4% [+0.9%, +2.0%]
BoidFlockers large 🔵 -1.1% [-1.6%, -0.7%] 🔵 +1.0% [+0.6%, +1.4%]

@quaquel quaquel self-requested a review February 29, 2024 19:08
Copy link
Contributor

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quaquel quaquel merged commit 05b9700 into projectmesa:main Feb 29, 2024
13 checks passed
@rht rht deleted the altair_size branch February 29, 2024 19:23
@EwoutH EwoutH added the enhancement Release notes label label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants