Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tutorial to follow new model standards #370

Merged
merged 1 commit into from
May 22, 2017
Merged

Update tutorial to follow new model standards #370

merged 1 commit into from
May 22, 2017

Conversation

djmitche
Copy link
Contributor

Fixes #333.

@coveralls
Copy link

coveralls commented May 22, 2017 •
edited

Coverage Status

Coverage remained the same at 76.408% when pulling d8878fb on djmitche:issue333 into 63ae794 on projectmesa:master.

@jackiekazil jackiekazil self-assigned this May 22, 2017
@jackiekazil
Copy link
Member

Looking at this now.

@jackiekazil
Copy link
Member

Right now we have run.py & server.py.
Everything that is viz related for the model & the actual running of the model go into server.py, while run.py just includes enough to call the server.py to run it.

Example of run.py: https://github.com/projectmesa/mesa/blob/master/examples/Schelling/run.py
Example of server.py: https://github.com/projectmesa/mesa/blob/master/examples/Schelling/server.py

@jackiekazil jackiekazil added this to the Flagstaff (PyCon Sprints) milestone May 22, 2017
@djmitche
Copy link
Contributor Author

OK, updated to use server.py and run the server from run.py.

@coveralls
Copy link

coveralls commented May 22, 2017 •
edited

Coverage Status

Coverage remained the same at 76.408% when pulling 3ceb092 on djmitche:issue333 into 173f4c5 on projectmesa:master.

jackiekazil
jackiekazil reviewed May 22, 2017
View reviewed changes
docs/tutorials/intro_tutorial.rst
@@ -277,6 +273,7 @@ graphics library) to visualize the data in a histogram.

.. code:: python

# run.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 276:285 -- as discussed separate this into 2 sections to be explicit for users -- 1 for direct file usages & 1 for jupyter notebook users.

@djmitche
Refactor tutorials to use properly named model, files
3deb576 
This also clarifies which snippets go in which files, and some other
minor cleanup of repetitive bits.
@djmitche
Copy link
Contributor Author

updated :)

@coveralls
Copy link

coveralls commented May 22, 2017 •
edited

Coverage Status

Coverage remained the same at 76.408% when pulling 3deb576 on djmitche:issue333 into 4c7297f on projectmesa:master.

@jackiekazil jackiekazil merged commit 40bfbb2 into projectmesa:master May 22, 2017
@jackiekazil
Copy link
Member

LGTM

@jackiekazil jackiekazil mentioned this pull request Jun 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackiekazil jackiekazil jackiekazil left review comments

Assignees

@jackiekazil jackiekazil

Labels
None yet
Projects
None yet
Milestone
Flagstaff (PyCon Sprints)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djmitche @coveralls @jackiekazil