Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to 9 March 18 feedback #484

Merged
merged 2 commits into from Mar 10, 2018
Merged

Correction to 9 March 18 feedback #484

merged 2 commits into from Mar 10, 2018

Conversation

tpike3
Copy link
Contributor

@tpike3 tpike3 commented Mar 9, 2018

Sorry inadvertently pull requested to main branch, I closed that pull request... same edits

Made the corrections requested

Also having a better feeling for your style and intent I made some additional changes to make it shorter and cleaner.

I deleted the package_template.rst that was no longer used.

I do have a package ready to put on the wiki at https://github.com/tpike3/bilateralshapley

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.09% when pulling 139bf3f on tpike3:master into 9a1dcba on projectmesa:mesa_packages_pages.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.09% when pulling 139bf3f on tpike3:master into 9a1dcba on projectmesa:mesa_packages_pages.

@jackiekazil
Copy link
Member

Fabulous! I am merging it into the branch. I will have feedback by Sunday.

@jackiekazil jackiekazil merged commit 7165638 into projectmesa:mesa_packages_pages Mar 10, 2018
@jackiekazil jackiekazil added this to the Jerome v0.8.4 milestone Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants