Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batchrunner.fix #596

Merged
merged 9 commits into from Nov 13, 2018
Merged

Batchrunner.fix #596

merged 9 commits into from Nov 13, 2018

Conversation

dmasad
Copy link
Member

@dmasad dmasad commented Oct 9, 2018

Extends #492 to work with BatchRunnerMP as well. Fixes #466 and makes variable_parameters optional for BatchRunner.

@jackiekazil
Copy link
Member

@dmasad I did a review of this. This all looks good. I will merge once the conflict is reviewed.

@dmasad
Copy link
Member Author

dmasad commented Nov 8, 2018

Conflict should be resolved.

@jackiekazil
Copy link
Member

@dmasad looks like there is one more... mesa/batchrunner.py?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 79.877% when pulling bc73117 on batchrunner.fix into e7e4f30 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 79.877% when pulling bc73117 on batchrunner.fix into e7e4f30 on master.

@dmasad
Copy link
Member Author

dmasad commented Nov 13, 2018

Should be fixed.

@jackiekazil
Copy link
Member

@dmasad we have had a few convos about this. Ty for taking this over the finishing line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants