Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schelling: Separate text-only viz into run_ascii.py #706

Merged
merged 3 commits into from
Jul 6, 2019

Conversation

rht
Copy link
Contributor

@rht rht commented Jul 6, 2019

This partially addresses #693.

The text-specific viz is moved to run_ascii.py, and so it'd be less confusing to read run.py.

@rht rht force-pushed the schelling-text branch 2 times, most recently from f5ee69e to 6e160a3 Compare July 6, 2019 00:34
@coveralls
Copy link

coveralls commented Jul 6, 2019

Coverage Status

Coverage remained the same at 76.989% when pulling e86ce30 on rht:schelling-text into aa81374 on projectmesa:master.

@dmasad
Copy link
Member

dmasad commented Jul 6, 2019

This looks good, though it looks like the functionality in TextGrid was broken at some point (since it was largely not in use). I'm going to approve, and then quickly add a fix.

@dmasad dmasad merged commit 7ca4b4e into projectmesa:master Jul 6, 2019
@rht
Copy link
Contributor Author

rht commented Jul 6, 2019

This was the final grid's output when I executed run_ascii.py:

Step: 9
XXXXXXXXXXXXX XXXXXX
XXXXXXXXXXXXXXXX XXX
XXXXX XXXXXXX  X XX 
 XX XXXXXXXXXX XXXX 
XXXXXXXXXXXXXXX XXXX
 XXXXX XXXX XX X XXX
XX  X XXXXXXXXXXXXXX
 XXX XXX XX XXXXXXX 
X XXXXX X XXXX X  XX
XXXXXXXXXXXXXXXXXXXX
XXXXXXX XXXXXX  XXXX
X XX  XX XXXX XX   X
   X  X XXXXXXXXXX X
XX XXXXXXXXXX  XXX X
XXXXXXXX  X XXXX  XX
X X XXXXXXX   XXXX X
XXXXXXXXXXXXX  XX XX
  XXXXXXX XXXX  XX X
X X XXXXXXXXXXXXXXXX
XX XXXXXXXXXX X XXXX

happy: 309
---

The O's aren't being printed out.

@dmasad
Copy link
Member

dmasad commented Jul 6, 2019

Yup, there was a problem with TextGrid. It was a one-line fix so I pushed it directly to master.

@rht rht deleted the schelling-text branch July 7, 2019 00:51
@guy1ziv2
Copy link

guy1ziv2 commented Jul 12, 2019

I am still getting only 'X' or ' ' with TextGrid, even when the converter is not supposed to print 'X' at all cases... I am trying to use TextGrid to visualize Conways Game of Life port in a Colab environment see https://colab.research.google.com/drive/1GJiWioQWk6Z3YnMdu-ZXDYUQs03O2eqN

@dmasad
Copy link
Member

dmasad commented Jul 14, 2019

@guy1ziv2 The new fix is just on GitHub at the moment, and the version on PyPI hasn't been updated yet. If you want to makes sure you're installing the most recent version, you need to pip-install directly from GitHub, i.e.

!pip install git+https://github.com/ProjectMesa/mesa.git

@jackiekazil jackiekazil added this to the Mammoth v0.8.7 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants