Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying annotations for intended target #3568

Open
jptmoore opened this issue Sep 1, 2022 · 2 comments
Open

Displaying annotations for intended target #3568

jptmoore opened this issue Sep 1, 2022 · 2 comments
Labels
annotations annotation display / viewing manifest compatibility Investigate why specific manifests are not loading or rendering correctly user experience

Comments

@jptmoore
Copy link

jptmoore commented Sep 1, 2022

Manifest URLs: https://miiifystore.s3.eu-west-2.amazonaws.com/iiif/annotest.json

Hi. When I view annotations and the annotation target does not match the canvas being displayed the annotation is still shown. Here is a simple example where the 2nd annotation is shown despite not having a matching canvas/target to display on: https://projectmirador.org/embed/?iiif-content=https://miiifystore.s3.eu-west-2.amazonaws.com/iiif/annotest.json

@jptmoore jptmoore added the annotations annotation display / viewing label Sep 1, 2022
@cbeer
Copy link
Collaborator

cbeer commented Sep 1, 2022

Thanks for the report, and the test case object. I had a look at the IIIF spec and I feel like there's some ambiguity about whether a canvases annotations can target other canvases:

The motivation of the Annotations must not be painting, and the target of the Annotations must include this resource or part of it.
https://iiif.io/api/presentation/3.0/#annotations

but later on, this seems reduced to a SHOULD (perhaps allowing canvas annotations to target contained content resources?):

All of the Annotations in the Annotation Page should have the Canvas as their target
https://iiif.io/api/presentation/3.0/#55-annotation-page

--

I think we also need some clarification about how to handle canvas annotations that target other canvases. Do we simply filter them out (because they are given in error, I guess?), or does mirador need to aggregate all the annotations in a IIIF presentation manifest (whether specified in the hierarchy for this canvas or elsewhere) to collect matching manifest, or some other behavior?

Can you share any real-world manifests with this behavior to help determine the appropriate user experience?

@cbeer cbeer added user experience manifest compatibility Investigate why specific manifests are not loading or rendering correctly labels Sep 1, 2022
@jptmoore
Copy link
Author

jptmoore commented Sep 2, 2022

Hi.

I think it makes sense that if you are applying annotations to a particular canvas those annotations would have the same target. What I am not sure how to handle is when the annotation page is retrieved from an annotation server where the annotations belong to a container that is not specific to a canvas. It is at another level of abstraction. For example, a container of cats containing multiple annotations with different targets like this: https://miiify.rocks/annotations/cats
This would require filtering on the target to avoid showing all annotations about cats on a single canvas. I wonder if there is another way to handle this in the manifest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotations annotation display / viewing manifest compatibility Investigate why specific manifests are not loading or rendering correctly user experience
Projects
None yet
Development

No branches or pull requests

2 participants