Clarify protobuf/Jackson examples in README #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
reviewed
Jun 6, 2023
tools/build.gradle.kts
Outdated
| dependencies { | ||
| api(project(":cel-core")) | ||
|
|
||
| testImplementation(platform(libs.junit.bom)) | ||
| testImplementation(libs.bundles.junit.testing) | ||
| testRuntimeOnly(libs.junit.jupiter.engine) | ||
| } | ||
|
|
||
| // *.proto files taken from https://github.com/googleapis/googleapis/ repo, available as a git | ||
| // submodule |
There was a problem hiding this comment.
not sure i understand what the comment is trying to tell me, what proto files are we referring to here?
README.md
Outdated
|
|
||
| ```java | ||
| public class MyClass { | ||
| public Boolean evalWIthProtobuf() { |
README.md
Outdated
| .buildScript("inp.Property1 == checkName") | ||
| .withDeclarations( | ||
| // protobuf types need the type's full name | ||
| Decls.newVar("inp", Decls.newObjectType(Dummy.MyPojo.getDescriptor().getFullName())), |
There was a problem hiding this comment.
might be unclear where Dummy is coming from, doesnt it depend on the proto filename?
in our tests its clear in the example it isnt imo
There was a problem hiding this comment.
Updated the readme (this "Dummy" came from the .proto file name in the test)
XN137
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.