BigTable backend: ability to disable telemetry (#7597)

projectnessie · Oct 9, 2023 · 113b349 · 113b349
1 parent 2a5b1d2
commit 113b349
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -26,6 +26,7 @@ as necessary. Empty sections will not end in the release notes.
   If a fixed cache size setting has been explicitly configured, consider to change it to the fraction based one.
 - Relative hashes are now supported in table references, thus allowing SQL queries to specify a relative hash
   in the `FROM` clause, e.g. `FROM table1@main#1234^1`.
+- BigTable backend: ability to disable telemetry (which is enabled by default).
 
 ### Deprecations
 

diff --git a/.../quarkus-common/src/main/java/org/projectnessie/quarkus/config/QuarkusBigTableConfig.java b/.../quarkus-common/src/main/java/org/projectnessie/quarkus/config/QuarkusBigTableConfig.java
@@ -65,4 +65,7 @@ public interface QuarkusBigTableConfig {
 
   @WithDefault("8086")
   int emulatorPort();
+
+  @WithDefault("true")
+  boolean enableTelemetry();
 }
diff --git a/...mon/src/main/java/org/projectnessie/quarkus/providers/storage/BigTableBackendBuilder.java b/...mon/src/main/java/org/projectnessie/quarkus/providers/storage/BigTableBackendBuilder.java
@@ -143,6 +143,11 @@ public Backend buildBackend() {
           bigTableConfig.initialRpcTimeout(),
           bigTableConfig.initialRetryDelay());
 
+      if (bigTableConfig.enableTelemetry()) {
+        BigtableDataSettings.enableOpenCensusStats();
+        BigtableDataSettings.enableGfeOpenCensusStats();
+      }
+
       LOGGER.info("Creating Google BigTable data client...");
       BigtableDataClient dataClient = BigtableDataClient.create(dataSettings.build());
 

diff --git a/site/docs/try/configuration.md b/site/docs/try/configuration.md
@@ -76,6 +76,7 @@ When setting `nessie.version.store.type=BIGTABLE` which enables Google BigTable
 | `nessie.version.store.persist.bigtable.initial-rpc-timeout`   | (unspecified)  | `Duration`            | Initial RPC timeout.                                                                                                     |
 | `nessie.version.store.persist.bigtable.initial-retry-delay`   | (unspecified)  | `Duration`            | Initial retry delay.                                                                                                     |
 | `nessie.version.store.persist.bigtable.max-retry-delay`       | (unspecified)  | `Duration`            | Max retry-delay.                                                                                                         |
+| `nessie.version.store.persist.bigtable.enable-telemetry`      | `true`         | `boolean`             | Enables telemetry with OpenCensus.                                                                                       |
 
 
 !!! info

diff --git a/...le/src/main/java/org/projectnessie/versioned/storage/bigtable/BigTableBackendFactory.java b/...le/src/main/java/org/projectnessie/versioned/storage/bigtable/BigTableBackendFactory.java
@@ -96,10 +96,6 @@ public static void configureDataClient(
             stubSettings.bulkReadRowsSettings().getBatchingSettings().toBuilder()
                 .setElementCountThreshold((long) BigTableConstants.MAX_BULK_READS)
                 .build());
-
-    // Enable tracing & metrics
-    BigtableDataSettings.enableOpenCensusStats();
-    BigtableDataSettings.enableGfeOpenCensusStats();
   }
 
   private static void configureDuration(