review: rename config, add doc

projectnessie · Oct 18, 2023 · 1bbc395 · 1bbc395
1 parent 6bb108b
commit 1bbc395
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.../quarkus-common/src/main/java/org/projectnessie/quarkus/config/QuarkusBigTableConfig.java b/.../quarkus-common/src/main/java/org/projectnessie/quarkus/config/QuarkusBigTableConfig.java
@@ -46,11 +46,11 @@ public interface QuarkusBigTableConfig {
 
   Optional<Duration> maxRetryDelay();
 
-  OptionalInt maxRpcAttempts();
+  OptionalInt maxAttempts();
 
   Optional<Duration> initialRpcTimeout();
 
-  Optional<Duration> totalRpcTimeout();
+  Optional<Duration> totalTimeout();
 
   Optional<Duration> initialRetryDelay();
 

diff --git a/...mon/src/main/java/org/projectnessie/quarkus/providers/storage/BigTableBackendBuilder.java b/...mon/src/main/java/org/projectnessie/quarkus/providers/storage/BigTableBackendBuilder.java
@@ -139,8 +139,8 @@ public Backend buildBackend() {
       configureDataClient(
           dataSettings,
           Optional.of(poolSettings),
-          bigTableConfig.totalRpcTimeout(),
-          bigTableConfig.maxRpcAttempts(),
+          bigTableConfig.totalTimeout(),
+          bigTableConfig.maxAttempts(),
           bigTableConfig.maxRetryDelay(),
           bigTableConfig.initialRpcTimeout(),
           bigTableConfig.initialRetryDelay());

diff --git a/site/docs/try/configuration.md b/site/docs/try/configuration.md
@@ -73,6 +73,8 @@ When setting `nessie.version.store.type=BIGTABLE` which enables Google BigTable
 | `nessie.version.store.persist.bigtable.initial-channel-count` | `1`            | `int`                 | Initial number of gRPC channels. Refer to Google docs for details.                                                       |
 | `nessie.version.store.persist.bigtable.min-rpcs-per-channel`  | `0`            | `int`                 | Minimum number of RPCs per channel. Refer to Google docs for details.                                                    |
 | `nessie.version.store.persist.bigtable.max-rpcs-per-channel`  | (unlimited)    | `int`                 | Maximum number of RPCs per channel. Refer to Google docs for details.                                                    |
+| `nessie.version.store.persist.bigtable.max-attempts`          | (unspecified)  | `int`                 | Maximum number of attempts for each Bigtable API call (including retries).                                               |
+| `nessie.version.store.persist.bigtable.total-timeout`         | (unspecified)  | `Duration`            | Total timeout (including retries) for Bigtable API calls.                                                                |
 | `nessie.version.store.persist.bigtable.initial-rpc-timeout`   | (unspecified)  | `Duration`            | Initial RPC timeout.                                                                                                     |
 | `nessie.version.store.persist.bigtable.initial-retry-delay`   | (unspecified)  | `Duration`            | Initial retry delay.                                                                                                     |
 | `nessie.version.store.persist.bigtable.max-retry-delay`       | (unspecified)  | `Duration`            | Max retry-delay.                                                                                                         |