Fix nit in TypeMapping (#7054)

projectnessie · Jun 15, 2023 · 364b30b · 364b30b
1 parent 7a8e841
commit 364b30b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...age/store/src/main/java/org/projectnessie/versioned/storage/versionstore/TypeMapping.java b/...age/store/src/main/java/org/projectnessie/versioned/storage/versionstore/TypeMapping.java
@@ -268,10 +268,10 @@ public static ImmutableCommitMeta.Builder headersToCommitMeta(
     return commitMeta;
   }
 
-  public static CreateCommit.Builder fromCommitMeta(
+  public static void fromCommitMeta(
       @Nonnull @jakarta.annotation.Nonnull CommitMeta commitMeta,
       @Nonnull @jakarta.annotation.Nonnull CreateCommit.Builder commit) {
-    return commit.headers(headersFromCommitMeta(commitMeta)).message(commitMeta.getMessage());
+    commit.headers(headersFromCommitMeta(commitMeta)).message(commitMeta.getMessage());
   }
 
   @Nonnull

diff --git a/...store/src/test/java/org/projectnessie/versioned/storage/versionstore/TestTypeMapping.java b/...store/src/test/java/org/projectnessie/versioned/storage/versionstore/TestTypeMapping.java
@@ -308,9 +308,9 @@ static Stream<Arguments> commitMeta() {
   @ParameterizedTest
   @MethodSource("commitMeta")
   public void commitMeta(CommitMeta commitMete, CreateCommit createCommit, CommitObj commitObj) {
-    soft.assertThat(
-            fromCommitMeta(commitMete, newCommitBuilder()).parentCommitId(EMPTY_OBJ_ID).build())
-        .isEqualTo(createCommit);
+    CreateCommit.Builder commitBuilder = newCommitBuilder();
+    fromCommitMeta(commitMete, commitBuilder);
+    soft.assertThat(commitBuilder.parentCommitId(EMPTY_OBJ_ID).build()).isEqualTo(createCommit);
     soft.assertThat(toCommitMeta(commitObj))
         .isEqualTo(commitMete)
         .extracting(CommitMeta::getHash)