Skip to content

Commit

Permalink
Remove unused Jaeger properties (#5647)
Browse files Browse the repository at this point in the history
This change is following up on #5605 and #5607
  • Loading branch information
dimas-b committed Dec 7, 2022
1 parent 19a82de commit da8c050
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 16 deletions.
1 change: 0 additions & 1 deletion gradle/libs.versions.toml
Expand Up @@ -141,7 +141,6 @@ jackson-dataformat-xml = { module = "com.fasterxml.jackson.dataformat:jackson-da
jackson-jaxrs-json-provider = { module = "com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider" }
jackson-jaxrs-xml-provider = { module = "com.fasterxml.jackson.jaxrs:jackson-jaxrs-xml-provider" }
jacoco-maven-plugin = { module = "org.jacoco:jacoco-maven-plugin", version.ref = "jacoco" }
jaeger-core = { module = "io.jaegertracing:jaeger-core", version = "1.8.1" }
jakarta-annotation-api = { module = "jakarta.annotation:jakarta.annotation-api", version = "1.3.5" }
jakarta-enterprise-cdi-api = { module = "jakarta.enterprise:jakarta.enterprise.cdi-api", version = "2.0.2" }
jakarta-validation-api = { module = "jakarta.validation:jakarta.validation-api", version = "2.0.2" }
Expand Down
2 changes: 0 additions & 2 deletions servers/quarkus-cli/src/main/resources/application.properties
Expand Up @@ -60,8 +60,6 @@ quarkus.log.console.level=WARN
quarkus.log.file.level=INFO
quarkus.log.file.format=%d{yyyy-MM-dd HH:mm:ss,SSS} %h %N[%i] %-5p [%X{traceId},%X{spanId},%X{sampled}] [%c{3.}] (%t) %s%e%n
quarkus.log.category."io.netty".level=WARN
# Don't log toggling warnings about "FlushCommand errors" + "FlushCommand working again" - see https://github.com/projectnessie/nessie/issues/1500
quarkus.log.category."io.jaegertracing.internal.reporters".level=ERROR
# Instruct jacoco to reuse output files to preserve coverage data across multiple test JVM restarts.
quarkus.jacoco.reuse-data-file=true

Expand Down
12 changes: 0 additions & 12 deletions servers/quarkus-server/src/main/resources/application.properties
Expand Up @@ -102,8 +102,6 @@ quarkus.log.console.level=INFO
quarkus.log.file.level=INFO
quarkus.log.file.format=%d{yyyy-MM-dd HH:mm:ss,SSS} %h %N[%i] %-5p [%X{traceId},%X{spanId},%X{sampled}] [%c{3.}] (%t) %s%e%n
quarkus.log.category."io.netty".level=WARN
# Don't log toggling warnings about "FlushCommand errors" + "FlushCommand working again" - see https://github.com/projectnessie/nessie/issues/1500
quarkus.log.category."io.jaegertracing.internal.reporters".level=ERROR
# Effectively disable HTTP request logging to the console (HTTP access logs happen at INFO level)
quarkus.log.category."io.quarkus.http.access-log".level=${HTTP_ACCESS_LOG_LEVEL:INFO}

Expand Down Expand Up @@ -133,15 +131,6 @@ quarkus.swagger-ui.enable=true

quarkus.application.name=Nessie

## Quarkus monitoring and tracing settings
## jaeger specific settings
quarkus.jaeger.service-name=nessie
quarkus.jaeger.sampler-type=ratelimiting
quarkus.jaeger.sampler-param=1
#quarkus.jaeger.endpoint=http://localhost:14268/api/traces
# fixed at buildtime
quarkus.jaeger.metrics.enabled=true

## sentry specific settings
quarkus.log.sentry.level=ERROR
quarkus.log.sentry.in-app-packages=org.projectnessie
Expand Down Expand Up @@ -184,7 +173,6 @@ quarkus.opentelemetry.tracer.enabled=true

# Overrides
## dev overrides - dev is used when running Nessie in dev mode `mvn quarkus:dev`
%dev.quarkus.jaeger.sampler-type=const
%dev.quarkus.dynamodb.endpoint-override=http://localhost:8000
%dev.quarkus.dynamodb.aws.credentials.type=STATIC
%dev.quarkus.dynamodb.aws.credentials.static-provider.access-key-id=test-key
Expand Down
Expand Up @@ -24,7 +24,7 @@ public class BaseConfigProfile implements QuarkusTestProfile {
public static final String TEST_REPO_ID = "nessie-test";

public static final Map<String, String> CONFIG_OVERRIDES =
ImmutableMap.<String, String>builder().put("quarkus.jaeger.sampler-type", "const").build();
ImmutableMap.<String, String>builder().build();

public static final Map<String, String> VERSION_STORE_CONFIG;

Expand Down

0 comments on commit da8c050

Please sign in to comment.