Remove httpClient param from AbstractRest.init #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
XN137
commented
Oct 11, 2022
XN137
commented
- the httpClient builder was effectively unused after Isolate http-level test from java client-level tests #5314
- also rename to initApi
- the httpClient builder was effectively unused - also rename to initApi
XN137
commented
Oct 11, 2022
| HttpClientBuilder.builder() | ||
| // Abuse the authentication callback a bit to inject the noAcceptFilter into | ||
| // the java client. | ||
| .withAuthentication( | ||
| (HttpAuthentication) client -> client.addRequestFilter(noAcceptFilter)) | ||
| .withUri(httpClient.getBaseUri()) | ||
| .withUri(nessieApiUri) |
There was a problem hiding this comment.
we only used the base uri from the passed in httpClient... so we should instead override initApi(URI)
| .build(NessieApiV1.class); | ||
|
|
||
| super.init(api, httpClient); | ||
| super.initApi(api); |
There was a problem hiding this comment.
super.init did not use httpClient
| } | ||
|
|
||
| protected void init(NessieApiV1 api, @Nullable HttpClient.Builder httpClient) { |
There was a problem hiding this comment.
httpClient param is ignored here (it used to be stored into a field previously)
ajantha-bhat
approved these changes
Oct 11, 2022
dimas-b
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
I'm thinking to move the Nessie client construction code into a JUnit5 extension and make it automatic for v1 and v2 API tests (based on #5339), but for now this looks like a reasonable refactoring. Thanks for cleaning this up :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.