Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to OpenTelemetry in Nessie Quarkus server #5605

Merged
merged 1 commit into from Dec 2, 2022

Conversation

snazy
Copy link
Member

@snazy snazy commented Dec 2, 2022

No description provided.

Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

I tried the naive approach of running:

env QUARKUS_OPENTELEMETRY_TRACER_EXPORTER_OTLP_ENDPOINT=http://localhost:55680 \
  java -jar servers/quarkus-server/build/quarkus-app/quarkus-run.jar 

... but did not get any traces reported for commits 🤔

Could you add a readme entry for setting up OTel, please?

@snazy
Copy link
Member Author

snazy commented Dec 2, 2022

Weird, I tried it with -Dquarkus.opentelemetry.tracer.exporter.otlp.endpoint=http://localhost:4317 before and it collected traces. Let me re-check.

@dimas-b
Copy link
Member

dimas-b commented Dec 2, 2022

I ran OTel servers in docker-composse following some (old) example

@snazy
Copy link
Member Author

snazy commented Dec 2, 2022

Works on my machine ™️
image

Buuut - maybe remove env from your command line?

@snazy
Copy link
Member Author

snazy commented Dec 2, 2022

I ran OTel servers in docker-composse following some (old) example

https://quarkus.io/guides/opentelemetry#run-the-application

@dimas-b
Copy link
Member

dimas-b commented Dec 2, 2022

Ah, I configured otlp/2 port

@dimas-b
Copy link
Member

dimas-b commented Dec 2, 2022

Yes, it works with port 4317... I wonder why it did not work with otlp/2, though 🤔

@@ -56,7 +56,7 @@ dependencies {
implementation("io.quarkus:quarkus-smallrye-openapi")
implementation("io.quarkus:quarkus-micrometer")
implementation("io.quarkus:quarkus-core-deployment")
implementation(libs.quarkus.smallrye.opentracing)
implementation(libs.quarkus.opentelemetry)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we need to explicitly depend on quarkus-opentelemetry-exporter-otlp for otlp/2 to work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 83.91% // Head: 79.23% // Decreases project coverage by -4.67% ⚠️

Coverage data is based on head (f8f4f15) compared to base (fea0958).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5605      +/-   ##
============================================
- Coverage     83.91%   79.23%   -4.68%     
- Complexity        0     3693    +3693     
============================================
  Files            30      532     +502     
  Lines          1473    16414   +14941     
  Branches        238     1599    +1361     
============================================
+ Hits           1236    13006   +11770     
- Misses          171     2786    +2615     
- Partials         66      622     +556     
Flag Coverage Δ
java 78.68% <ø> (∅)
javascript 82.91% <ø> (∅)
python 83.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/projectnessie/versioned/Operation.java 100.00% <0.00%> (ø)
...essie/services/rest/ValidationExceptionMapper.java 12.50% <0.00%> (ø)
...e/error/NessieReferenceAlreadyExistsException.java 71.42% <0.00%> (ø)
...jectnessie/services/rest/RestV2ConfigResource.java 0.00% <0.00%> (ø)
.../projectnessie/services/impl/NamespaceApiImpl.java 68.80% <0.00%> (ø)
.../java/org/projectnessie/services/impl/RefUtil.java 88.00% <0.00%> (ø)
...n/java/org/projectnessie/model/RefLogResponse.java 100.00% <0.00%> (ø)
.../projectnessie/versioned/ContentAttachmentKey.java 100.00% <0.00%> (ø)
...nessie/versioned/persist/adapter/KeyWithBytes.java 100.00% <0.00%> (ø)
...sie/client/builder/BaseMergeTransplantBuilder.java 27.27% <0.00%> (ø)
... and 492 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snazy snazy merged commit f7d64cd into projectnessie:main Dec 2, 2022
@snazy snazy deleted the otel branch December 2, 2022 15:16
dimas-b added a commit to dimas-b/nessie that referenced this pull request Dec 6, 2022
dimas-b added a commit that referenced this pull request Dec 7, 2022
This change is following up on #5605 and #5607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-native run native test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants