New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to OpenTelemetry in Nessie Quarkus server #5605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
I tried the naive approach of running:
env QUARKUS_OPENTELEMETRY_TRACER_EXPORTER_OTLP_ENDPOINT=http://localhost:55680 \
java -jar servers/quarkus-server/build/quarkus-app/quarkus-run.jar
... but did not get any traces reported for commits 🤔
Could you add a readme entry for setting up OTel, please?
Weird, I tried it with |
I ran OTel servers in docker-composse following some (old) example |
|
Ah, I configured otlp/2 port |
Yes, it works with port |
@@ -56,7 +56,7 @@ dependencies { | |||
implementation("io.quarkus:quarkus-smallrye-openapi") | |||
implementation("io.quarkus:quarkus-micrometer") | |||
implementation("io.quarkus:quarkus-core-deployment") | |||
implementation(libs.quarkus.smallrye.opentracing) | |||
implementation(libs.quarkus.opentelemetry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we need to explicitly depend on quarkus-opentelemetry-exporter-otlp
for otlp/2
to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportBase: 83.91% // Head: 79.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5605 +/- ##
============================================
- Coverage 83.91% 79.23% -4.68%
- Complexity 0 3693 +3693
============================================
Files 30 532 +502
Lines 1473 16414 +14941
Branches 238 1599 +1361
============================================
+ Hits 1236 13006 +11770
- Misses 171 2786 +2615
- Partials 66 622 +556
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This change is following up on projectnessie#5605 and projectnessie#5607
No description provided.