Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nessie native image for arm64 #6094

Closed
tmnd1991 opened this issue Feb 14, 2023 · 6 comments
Closed

Nessie native image for arm64 #6094

tmnd1991 opened this issue Feb 14, 2023 · 6 comments

Comments

@tmnd1991
Copy link
Contributor

Description:
Right now nessie docker image is published only for amd64 architecture.
It would be good to publish the image also for arm64.

Requested Changes in public API:

  • ❌Changes in REST API
  • ❌Changes in Java Client API
  • ❌Changes in Python Client API
  • ❌Changes in SQL extentions
  • ✅Changes in build/publish

Expected Use Cases:
Run Nessie natively on arm64 machines.

@tmnd1991
Copy link
Contributor Author

I dig a bit in the build and I understood that Nessie is using jib to build the container image.

quarkus.jib.platforms could be used to set the arm64 architecture, but unfortunately the "multi" platform feature of jib does not work for native image, so unfortunately two different steps/workflows would be needed to make it work.

Would you accept a PR on this?

tmnd1991 pushed a commit to tmnd1991/nessie that referenced this issue Feb 14, 2023
@dimas-b
Copy link
Member

dimas-b commented Feb 14, 2023

Thanks for the PR 👁️

tmnd1991 pushed a commit to tmnd1991/nessie that referenced this issue Feb 14, 2023
@snazy
Copy link
Member

snazy commented Feb 16, 2023

Closed after discussion in and in favor of #6099

@snazy snazy closed this as completed Feb 16, 2023
@snazy
Copy link
Member

snazy commented Feb 16, 2023

Closed after discussion in and in favor of #6099 / #6110

@snazy snazy closed this as completed Feb 16, 2023
@snazy
Copy link
Member

snazy commented Feb 17, 2023

Oh, and what I haven't really realized before: GitHub offers only offers runners on x86_64, none for amd64/aarch64. In other words, we'd have had no chance to build the amd64/aarch64 native binaries in CI :(

@tmnd1991
Copy link
Contributor Author

Yeah, that sucks :( you probably need custom runners to do so. I know the guys at typelevel managed to have them, but never investigated how

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants