REST V2: Key ranges for entries + diff #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
key-ranges
branch
4 times, most recently
from
cbdcedb
to
20ec663
Compare
dimas-b
reviewed
May 9, 2023
api/model/src/main/java/org/projectnessie/api/v2/doc/ApiDoc.java
Outdated
Show resolved
Hide resolved
api/model/src/main/java/org/projectnessie/api/v2/doc/ApiDoc.java
Outdated
Show resolved
Hide resolved
api/model/src/main/java/org/projectnessie/api/v2/params/KeyRangeParams.java
Show resolved
Hide resolved
...e/store/src/main/java/org/projectnessie/versioned/storage/versionstore/VersionStoreImpl.java
Outdated
Show resolved
Hide resolved
api/client/src/main/java/org/projectnessie/client/http/v2api/HttpGetDiff.java
Show resolved
Hide resolved
snazy
force-pushed
the
key-ranges
branch
4 times, most recently
from
03c5fcb
to
6187611
Compare
dimas-b
reviewed
May 10, 2023
.../storage/store/src/main/java/org/projectnessie/versioned/storage/versionstore/KeyRanges.java
Outdated
Show resolved
Hide resolved
...rage/store/src/test/java/org/projectnessie/versioned/storage/versionstore/TestKeyRanges.java
Outdated
Show resolved
Hide resolved
...rsist/store/src/main/java/org/projectnessie/versioned/persist/store/PersistVersionStore.java
Outdated
Show resolved
Hide resolved
...rage/store/src/test/java/org/projectnessie/versioned/storage/versionstore/TestKeyRanges.java
Outdated
Show resolved
Hide resolved
dimas-b
reviewed
May 10, 2023
...torage/common/src/main/java/org/projectnessie/versioned/storage/common/indexes/StoreKey.java
Outdated
Show resolved
Hide resolved
dimas-b
reviewed
May 10, 2023
...torage/common/src/main/java/org/projectnessie/versioned/storage/common/indexes/StoreKey.java
Outdated
Show resolved
Hide resolved
|
Reverted the |
dimas-b
reviewed
May 13, 2023
...torage/common/src/main/java/org/projectnessie/versioned/storage/common/indexes/StoreKey.java
Outdated
Show resolved
Hide resolved
.../common/src/main/java/org/projectnessie/versioned/storage/common/indexes/StoreIndexImpl.java
Outdated
Show resolved
Hide resolved
.../storage/store/src/main/java/org/projectnessie/versioned/storage/versionstore/KeyRanges.java
Show resolved
Hide resolved
...e/store/src/main/java/org/projectnessie/versioned/storage/versionstore/VersionStoreImpl.java
Show resolved
Hide resolved
snazy
force-pushed
the
key-ranges
branch
2 times, most recently
from
608020b
to
99db9e0
Compare
dimas-b
reviewed
May 16, 2023
api/model/src/main/java/org/projectnessie/api/v2/doc/ApiDoc.java
Outdated
Show resolved
Hide resolved
...e/store/src/main/java/org/projectnessie/versioned/storage/versionstore/VersionStoreImpl.java
Show resolved
Hide resolved
dimas-b
reviewed
May 17, 2023
api/client/src/main/java/org/projectnessie/client/http/v1api/HttpGetEntries.java
Show resolved
Hide resolved
dimas-b
previously approved these changes
May 17, 2023
* In "diff" API * In "get entries" This is just an API-level change to reserve REST paths and query parameters. Server-side implementation to be done separately. Closes projectnessie#5591
dimas-b
previously approved these changes
May 17, 2023
dimas-b
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon the work in #5656.
However, the "get range of contents" has been removed, because it's tricky to add it to the current Nessie Java API and since it's probably not a very useful functionality. It would also require adding paging and min/max-keys to the
GetMultipleContentRequest/Responsetypes to leverage the existing paging infrastructure and/or addContentsParamsparameter object - neither works well with the existing code.Adds the necessary
VersionStorechanges, which are pretty straight forward.Fixes #3957
Fixes #5591