Add convenience Content.withId(String)
#6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
reviewed
May 30, 2023
adutra
reviewed
May 30, 2023
| @@ -97,6 +97,8 @@ public interface Type { | |||
| @JsonIgnore | |||
| public abstract Type getType(); | |||
|
|
|||
| public abstract Content withId(String id); | |||
There was a problem hiding this comment.
Maybe:
Suggested change
| public abstract Content withId(String id); | |
| public abstract Content withId(@Nullable @jakarta.annotation.Nullable String id); |
Conversely we could require id to be non null and introduce a withoutId() method, wdyt?
There was a problem hiding this comment.
Nope - ID must be nullable - otherwise you could never add new content
...age/store/src/main/java/org/projectnessie/versioned/storage/versionstore/ContentMapping.java
Show resolved
Hide resolved
versioned/tests/src/main/java/org/projectnessie/versioned/testworker/OnRefOnly.java
Outdated
Show resolved
Hide resolved
api/model/src/main/java/org/projectnessie/model/CommitResponse.java
Outdated
Show resolved
Hide resolved
dimas-b
reviewed
May 30, 2023
api/model/src/main/java/org/projectnessie/model/CommitResponse.java
Outdated
Show resolved
Hide resolved
dimas-b
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.