-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience Content.withId(String)
#6937
Conversation
@@ -97,6 +97,8 @@ public interface Type { | |||
@JsonIgnore | |||
public abstract Type getType(); | |||
|
|||
public abstract Content withId(String id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
public abstract Content withId(String id); | |
public abstract Content withId(@Nullable @jakarta.annotation.Nullable String id); |
Conversely we could require id
to be non null and introduce a withoutId()
method, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope - ID must be nullable - otherwise you could never add new content
No description provided.