New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Docker images for the GC tool #8055
Conversation
-g ":nessie-gc-tool" \ | ||
-p "gc/gc-tool" \ | ||
-d "Dockerfile-gctool" \ | ||
ghcr.io/projectnessie/nessie-gc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snazy This would end up as a new repo in Quay and DockerHub as well. Do we need to create those repos upfront? Do we need to change regsync settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regsync.yml
file needs to be changed, yes.
I think we don't need to create repos upfront. Let's see whether the snapshot-publish job has something to complain - I guess not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
-g ":nessie-gc-tool" \ | ||
-p "gc/gc-tool" \ | ||
-d "Dockerfile-gctool" \ | ||
ghcr.io/projectnessie/nessie-gc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regsync.yml
file needs to be changed, yes.
I think we don't need to create repos upfront. Let's see whether the snapshot-publish job has something to complain - I guess not.
FROM registry.access.redhat.com/ubi9/openjdk-21:1.17-2.1705482269 | ||
|
||
LABEL org.opencontainers.image.source=https://github.com/projectnessie/nessie | ||
LABEL org.opencontainers.image.description="ProjectNessie GC Tool" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LABEL org.opencontainers.image.description="ProjectNessie GC Tool" | |
LABEL org.opencontainers.image.description="Projectnessie GC Tool" |
.github/docker-sync/regsync.yml
Outdated
- source: ghcr.io/projectnessie/nessie-gc-unstable | ||
target: quay.io/projectnessie/nessie-gc-unstable | ||
type: repository | ||
tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can omit the tags here. We needed those for Nessie to not mirror super-old versions.
Since you're already touching this file - can you change the regex for Nessie server above to something like 0[.][789]\\d[.].*|[123][.].*
- to include everything like 0.7[0-9]....
and newer - and 1.xxx
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit left
Co-authored-by: Robert Stupp <snazy@snazy.de>
Fixes #8054