Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Docker images for the GC tool #8055

Merged
merged 7 commits into from Feb 14, 2024
Merged

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Feb 13, 2024

Fixes #8054

-g ":nessie-gc-tool" \
-p "gc/gc-tool" \
-d "Dockerfile-gctool" \
ghcr.io/projectnessie/nessie-gc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snazy This would end up as a new repo in Quay and DockerHub as well. Do we need to create those repos upfront? Do we need to change regsync settings?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regsync.yml file needs to be changed, yes.

I think we don't need to create repos upfront. Let's see whether the snapshot-publish job has something to complain - I guess not.

@dimas-b dimas-b requested a review from snazy February 13, 2024 16:01
dimas-b
dimas-b previously approved these changes Feb 13, 2024
Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

-g ":nessie-gc-tool" \
-p "gc/gc-tool" \
-d "Dockerfile-gctool" \
ghcr.io/projectnessie/nessie-gc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regsync.yml file needs to be changed, yes.

I think we don't need to create repos upfront. Let's see whether the snapshot-publish job has something to complain - I guess not.

FROM registry.access.redhat.com/ubi9/openjdk-21:1.17-2.1705482269

LABEL org.opencontainers.image.source=https://github.com/projectnessie/nessie
LABEL org.opencontainers.image.description="ProjectNessie GC Tool"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LABEL org.opencontainers.image.description="ProjectNessie GC Tool"
LABEL org.opencontainers.image.description="Projectnessie GC Tool"

- source: ghcr.io/projectnessie/nessie-gc-unstable
target: quay.io/projectnessie/nessie-gc-unstable
type: repository
tags:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can omit the tags here. We needed those for Nessie to not mirror super-old versions.
Since you're already touching this file - can you change the regex for Nessie server above to something like 0[.][789]\\d[.].*|[123][.].* - to include everything like 0.7[0-9].... and newer - and 1.xxx as well.

snazy
snazy previously approved these changes Feb 14, 2024
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit left

.github/workflows/release-publish.yml Outdated Show resolved Hide resolved
Co-authored-by: Robert Stupp <snazy@snazy.de>
@snazy snazy merged commit 3244efe into projectnessie:main Feb 14, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Provide Docker image for GC tool
3 participants