Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable errorprone for generated sources #3027

Merged
merged 1 commit into from Jan 10, 2022

Conversation

snazy
Copy link
Member

@snazy snazy commented Jan 10, 2022

Skips running errorprone on generated source file.

Also fixes the maven-compiler-plugin configuration in :nessie-versioned-persist-bench to not include errorprone options.

@snazy snazy requested a review from nastra January 10, 2022 13:12
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #3027 (e77487e) into main (97e9001) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3027   +/-   ##
=========================================
  Coverage     85.49%   85.49%           
  Complexity     2211     2211           
=========================================
  Files           282      282           
  Lines         12823    12823           
  Branches        946      946           
=========================================
  Hits          10963    10963           
  Misses         1513     1513           
  Partials        347      347           
Flag Coverage Δ
java 85.78% <ø> (ø)
javascript 78.48% <ø> (ø)
python 84.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e9001...e77487e. Read the comment docs.

@snazy snazy merged commit e6e8561 into projectnessie:main Jan 10, 2022
@snazy snazy deleted the skip-errorprone-generated-sources branch March 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants