Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jaxb-impl from hadoop-common #6485

Merged
merged 1 commit into from
Apr 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions gc/gc-iceberg-files/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ dependencies {
exclude("org.eclipse.jetty")
exclude("org.apache.zookeeper")
}
// Bump the jabx-impl version 2.2.3-1 via hadoop-common to make it work with Java 17+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment seems wrong? In gradle/libs.versions.toml, the version is 2.3.8, not 2.2.3-1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, you probably meant "bump from" not "bump to" :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, the dependency comes "via" hadoop-common ;)

implementation(libs.jaxb.impl)

implementation(libs.iceberg.core)
implementation(libs.iceberg.aws)

Expand Down
2 changes: 2 additions & 0 deletions gc/gc-tool-inttest/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ dependencies {
exclude("org.apache.hadoop")
exclude("org.apache.zookeeper")
}
// Bump the jabx-impl version 2.2.3-1 via hadoop-common to make it work with Java 17+
implementation(libs.jaxb.impl)

implementation(libs.slf4j.api)

Expand Down
2 changes: 2 additions & 0 deletions gc/gc-tool/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ dependencies {
exclude("org.apache.hadoop")
exclude("org.apache.zookeeper")
}
// Bump the jabx-impl version 2.2.3-1 via hadoop-common to make it work with Java 17+
implementation(libs.jaxb.impl)

implementation(platform(libs.awssdk.bom))
runtimeOnly(libs.awssdk.s3)
Expand Down
1 change: 1 addition & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ javax-servlet = { module = "javax.servlet:javax.servlet-api", version = "4.0.1"
javax-validation-api = { module = "javax.validation:validation-api", version = "2.0.1.Final"}
javax-ws-rs = { module = "javax.ws.rs:javax.ws.rs-api", version = "2.1.1" }
javax-ws-rs21 = { module = "org.jboss.spec.javax.ws.rs:jboss-jaxrs-api_2.1_spec", version = "2.0.2.Final" }
jaxb-impl = { module = "com.sun.xml.bind:jaxb-impl", version = "2.3.8" }
jersey-bom = { module = "org.glassfish.jersey:jersey-bom", version = "2.39.1" }
jetbrains-annotations = { module = "org.jetbrains:annotations", version = "24.0.1" }
jmh-core = { module = "org.openjdk.jmh:jmh-core", version.ref = "jmh" }
Expand Down