Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native image #6847

Merged
merged 2 commits into from
May 19, 2023
Merged

Remove native image #6847

merged 2 commits into from
May 19, 2023

Conversation

snazy
Copy link
Member

@snazy snazy commented May 17, 2023

The native image isn't used in the wild (10 total pulls for 0.58.0+0.58.1 vs ~500 for the Java image).

There are already issues w/ native images. Spanner + BigTable (effectively all Google services) don't work in native images due to code issues in Google code. Also there are "strange" native-test issues in the Quarkus 3 PR.

FaaS (lambda) style deployments do not really need native images. Sure, the startup is faster, but those instances cannot run for long, because SerialGC can easily cause STWs of many seconds. So keeping FaaS instances up longer (and maybe have a "spare one") should mitigate that issue.

Also, we can only build x86_64/Linux native images.

@snazy snazy marked this pull request as ready for review May 17, 2023 17:43
dimas-b
dimas-b previously approved these changes May 17, 2023
@snazy snazy force-pushed the remove-native-image branch 2 times, most recently from 412edd4 to c7b7406 Compare May 18, 2023 06:50
@snazy snazy added this to the 0.60.0 milestone May 18, 2023
@adutra
Copy link
Contributor

adutra commented May 18, 2023

CI intTest Quarkus native needs to be removed from the list of required jobs.

@snazy snazy merged commit bc20c34 into projectnessie:main May 19, 2023
23 checks passed
@snazy snazy deleted the remove-native-image branch May 19, 2023 14:47
snazy added a commit to snazy/nessie that referenced this pull request May 24, 2023
snazy added a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants