Micro-optimizations in ContentKey + TypeMapping #6975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
reviewed
Jun 5, 2023
| } | ||
| if (e.isEmpty()) { | ||
| int l = e.length(); | ||
| sum += l; |
There was a problem hiding this comment.
Since we are micro-optimizing, this statement could be moved to line 189.
There was a problem hiding this comment.
That would optimize for the bad case though.
| if (sum > MAX_LENGTH) { | ||
| throw new IllegalStateException("Key too long, max allowed length: " + MAX_LENGTH); | ||
| } | ||
| if (elements.size() > MAX_ELEMENTS) { |
There was a problem hiding this comment.
This if block could be moved to line 169: there is no point in iterating over the elements, if we know that there are too many elements.
There was a problem hiding this comment.
That would optimize for the bad case though.
| @@ -196,7 +196,11 @@ private static StringBuilder keyToStoreKeyPrepare( | |||
| // Note: the relative values of outer and inner (key elements) separators affect the correctness | |||
| // of StoreKey comparisons WRT to ContentKey comparisons. The inner separator must be greater | |||
| // than the outer separator because longer ContentKeys are greater than shorter ContentKeys. | |||
| StringBuilder sb = new StringBuilder(); | |||
| int len = 4; | |||
adutra
approved these changes
Jun 5, 2023
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Jun 5, 2023
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Jun 5, 2023
snazy
added a commit
that referenced
this pull request
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.