Refactor ContentMapping.fetchContents
#7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
fetch-contents-dup-ids
branch
from
80a21cb
to
e238093
Compare
There is a *very* low chance (only for old, migrated repositories) that the exact same content object is used for multiple content-keys. If that situation happens, restart with a special, slower and more expensive implementation. It could have only happened before the enforcement of new content-IDs for Put-operations was in place _and_ if the content-ID was explicitly specified by a client.
snazy
force-pushed
the
fetch-contents-dup-ids
branch
from
e238093
to
7d7a49f
Compare
adutra
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a very low chance (only for old, migrated repositories) that the exact same content object is used for multiple content-keys. If that situation happens, restart with a special, slower and more expensive implementation. It could have only happened before the enforcement of new content-IDs for Put-operations was in place and if the content-ID was explicitly specified by a client.