Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart: disable OpenTelemetry SDK when tracing is disabled #7459

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Helm chart: disable OpenTelemetry SDK when tracing is disabled #7459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ as necessary. Empty sections will not end in the release notes.
commands.
- Content Generator tool: tool now prints the total number of elements returned when running the
`commits`, `references` and `entries` commands.
- Helm charts: OpenTelemetry SDK is now completely disabled when tracing is disabled.

### Deprecations

Expand Down
3 changes: 3 additions & 0 deletions helm/nessie/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ spec:
value: {{ .Values.tracing.sample | quote }}
{{- end }}
{{- end }}
{{- else }}
- name: QUARKUS_OTEL_SDK_DISABLED
value: "true"
{{- end }}

{{ list .Values.advancedConfig "" | include "nessie.propsToEnvVars" | nindent 12 }}
Expand Down