Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigTable backend: ability to disable telemetry #7597

Merged
merged 2 commits into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ as necessary. Empty sections will not end in the release notes.
If a fixed cache size setting has been explicitly configured, consider to change it to the fraction based one.
- Relative hashes are now supported in table references, thus allowing SQL queries to specify a relative hash
in the `FROM` clause, e.g. `FROM table1@main#1234^1`.
- BigTable backend: ability to disable telemetry (which is enabled by default).

### Deprecations

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,7 @@ public interface QuarkusBigTableConfig {

@WithDefault("8086")
int emulatorPort();

@WithDefault("true")
boolean enableTelemetry();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the docs on the website as well?

}
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@ public Backend buildBackend() {
bigTableConfig.initialRpcTimeout(),
bigTableConfig.initialRetryDelay());

if (bigTableConfig.enableTelemetry()) {
BigtableDataSettings.enableOpenCensusStats();
BigtableDataSettings.enableGfeOpenCensusStats();
}

LOGGER.info("Creating Google BigTable data client...");
BigtableDataClient dataClient = BigtableDataClient.create(dataSettings.build());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ public static void configureDataClient(
stubSettings.bulkReadRowsSettings().getBatchingSettings().toBuilder()
.setElementCountThreshold((long) BigTableConstants.MAX_BULK_READS)
.build());

// Enable tracing & metrics
BigtableDataSettings.enableOpenCensusStats();
BigtableDataSettings.enableGfeOpenCensusStats();
}

private static void configureDuration(
Expand Down