Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Extension SHOW LOG with AT #8294

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

SQL Extension SHOW LOG with AT #8294

wants to merge 5 commits into from

Conversation

leewjae
Copy link

@leewjae leewjae commented Apr 3, 2024 •
edited by snazy

Fixes #4665

dimas-b
dimas-b requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution @leewjae !

The idea LGTM in general. Please see a couple of concerns below.

...tensions-base/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowLogExec.scala Outdated
val refName = branch
.map(unquoteRefName)
.getOrElse(
NessieUtils.getCurrentRef(api, currentCatalog, catalog).getName
)

val ref = NessieUtils.calculateRef(refName, timestampOrHash, api)
NessieUtils.setCurrentRefForSpark(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is correct. We probably do not want the SHOW LOG command to change the catalog's active reference (which is the duty of USE REFERENCE).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now learning how the nessie code works. Changed!

...ts/src/main/java/org/projectnessie/spark/extensions/AbstractNessieSparkSqlExtensionTest.java Outdated

// here we are skipping commit time as its variable
assertThat(
sql("SHOW LOG %s AT %s IN nessie", refName, defaultHash()).stream()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this test is specific enough as it does not distinguish getting the full log from HEAD and getting log from an older commit.

@snazy snazy changed the title SQL Extension SHOW LOG with AT #4665 SQL Extension SHOW LOG with AT Apr 4, 2024
snazy
snazy reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM - just one test case missing

...ts/src/main/java/org/projectnessie/spark/extensions/AbstractNessieSparkSqlExtensionTest.java
void showLogAt() throws NessieConflictException, NessieNotFoundException {
List<SparkCommitLogEntry> resultList = createBranchCommitAndReturnLog();

// here we are skipping commit time as its variable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test using the timestamp as in throwWhenUseShowReferencesAtTimestampWithoutTimeZone() ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snazy snazy snazy left review comments

@dimas-b dimas-b dimas-b requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Extension SHOW LOG with AT
3 participants
@leewjae @snazy @dimas-b