Nessie server: add support for MariaDB and MySQL backends #8544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
force-pushed
the
mysql-support-server
branch
2 times, most recently
from
129f697
to
82f28d8
Compare
adutra
commented
May 21, 2024
...storage/jdbc/src/main/java/org/projectnessie/versioned/storage/jdbc/AbstractJdbcPersist.java
Outdated
Show resolved
Hide resolved
adutra
commented
May 21, 2024
...d/storage/jdbc/src/main/java/org/projectnessie/versioned/storage/jdbc/DatabaseSpecifics.java
Show resolved
Hide resolved
adutra
force-pushed
the
mysql-support-server
branch
from
82f28d8
to
619cfef
Compare
snazy
reviewed
May 21, 2024
servers/quarkus-server/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
servers/quarkus-common/src/main/java/org/projectnessie/quarkus/config/QuarkusJdbcConfig.java
Show resolved
Hide resolved
...main/java/org/projectnessie/quarkus/tests/profiles/BigTableTestResourceLifecycleManager.java
Outdated
Show resolved
Hide resolved
Which changes are unrelated? All the changes in the persist layer were done in order to optimize the configuration of Quarkus tests, by introducing the new The only change that is a bit unrelated indeed is the one I mentioned here: I will move that one to another PR. |
adutra
changed the title
adutra
force-pushed
the
mysql-support-server
branch
from
560f19e
to
a9ebc42
Compare
adutra
force-pushed
the
mysql-support-server
branch
from
a9ebc42
to
011d87e
Compare
adutra
changed the title
|
Ready for review again! |
snazy
reviewed
May 22, 2024
...src/main/java/org/projectnessie/quarkus/tests/profiles/QuarkusTestProfilePersistMariaDB.java
Show resolved
Hide resolved
servers/quarkus-common/src/main/java/org/projectnessie/quarkus/config/QuarkusJdbcConfig.java
Outdated
Show resolved
Hide resolved
...us-common/src/main/java/org/projectnessie/quarkus/config/datasource/DataSourceActivator.java
Outdated
Show resolved
Hide resolved
...us-common/src/main/java/org/projectnessie/quarkus/config/datasource/DataSourceActivator.java
Outdated
Show resolved
Hide resolved
...us-common/src/main/java/org/projectnessie/quarkus/config/datasource/DataSourceActivator.java
Outdated
Show resolved
Hide resolved
...us-common/src/main/java/org/projectnessie/quarkus/config/datasource/DataSourceActivator.java
Outdated
Show resolved
Hide resolved
...us-common/src/main/java/org/projectnessie/quarkus/config/datasource/DataSourceActivator.java
Outdated
Show resolved
Hide resolved
snazy
reviewed
May 22, 2024
snazy
reviewed
May 22, 2024
...us-common/src/main/java/org/projectnessie/quarkus/config/datasource/DataSourceActivator.java
Show resolved
Hide resolved
snazy
reviewed
May 22, 2024
...kus-common/src/main/java/org/projectnessie/quarkus/providers/storage/JdbcBackendBuilder.java
Show resolved
Hide resolved
snazy
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.