Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post: support for MariaDB and MySQL backends #8577

Merged
merged 1 commit into from
May 23, 2024

Conversation

adutra
Copy link
Contributor

@adutra adutra commented May 23, 2024

No description provided.

@adutra adutra requested review from snazy and dimas-b May 23, 2024 13:48
Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice blog post 👍 Just one minor usability comment / question.

```

2. Declare the JDBC datasource to use as `mariadb` (_this should be done regardless of whether you
are using MariaDB or MySQL_):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have mysql as an alias for user convenience? I imagine MySQL users will tend to think about their datasource as "MySQL" in daily activities... The JDBC URL will remain jdbc:mariadb:, of course, but config-wise it might be easier for users to manage quarkus.datasource.mysql.username=my_user. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea! Yes, I think we can add a 3rd datasource quarkus.datasource.mysql, its db-kind must be mariadb of course, but it could make the user XP slightly better indeed. Besides, if there are specificities for MySQL, these could easily go under quarkus.datasource.mysql.jdbc.additional-jdbc-properties without affecting MariaDB connections.

Also, it might be possible to create a ConfigSourceInterceptor that would transparently change jdbc:mysql to jdbc:mariadb in all JDBC urls.

@snazy snazy merged commit c473203 into projectnessie:main May 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants