Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix out-of-disk-space #373

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

snazy
Copy link
Member

@snazy snazy commented Aug 23, 2023

NesQuEIT CI recently started to fail with some "out of disk space" errors.
This PR removes a of unused stuff (Docker images and installed data).

For reference, failing jobs: https://github.com/projectnessie/query-engine-integration-tests/actions/runs/5941247890 + https://github.com/projectnessie/query-engine-integration-tests/actions/runs/5946855947

@snazy snazy force-pushed the fix-out-of-disk-space branch 4 times, most recently from 082e504 to 888c648 Compare August 23, 2023 09:09
@snazy snazy changed the title WIP Fix out-of-disk-space CI: Fix out-of-disk-space Aug 23, 2023
@snazy snazy marked this pull request as ready for review August 23, 2023 09:16
@snazy snazy requested a review from XN137 August 23, 2023 09:16
snazy added a commit to snazy/nessie that referenced this pull request Aug 23, 2023
See also projectnessie/query-engine-integration-tests#373

This change also adds the "free disk space" action added to NesQuEIT, although it is currently unused by Nessie.
XN137
XN137 previously approved these changes Aug 23, 2023
Copy link
Contributor

@XN137 XN137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look OK but idk how much of these "preloaded" things are part of the "full github runner"-functionality ...

if obscure errors appear in CI in the future these cleanups might be the culprit

shell: bash
run: |
# 2.2G /usr/share/dotnet
sudo rm -rf /usr/share/dotnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik the github runner is written on dotnet platform so removing this looks somewhat risky

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it's fine.
Quarkus does the same.

# node 14-alpine 0dac3dc27b1a 4 months ago 119MB
# node 16 ebdc80ddefea 6 days ago 909MB
# node 16-alpine 2573171e0124 12 days ago 118MB
# node 18 95d8a703ee8c 6 days ago 1.09GB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we removed only the 3 big node images, wouldnt we have enough room for a long time?

@snazy snazy merged commit 3867279 into projectnessie:main Aug 23, 2023
4 checks passed
@snazy snazy deleted the fix-out-of-disk-space branch August 23, 2023 09:43
snazy added a commit to projectnessie/nessie that referenced this pull request Aug 23, 2023
See also projectnessie/query-engine-integration-tests#373

This change also adds the "free disk space" action added to NesQuEIT, although it is currently unused by Nessie.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants