Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arduino Adapter Test #29

Closed
ATATC opened this issue Jan 18, 2024 · 3 comments
Closed

Arduino Adapter Test #29

ATATC opened this issue Jan 18, 2024 · 3 comments
Labels
bug Something isn't working code review Code review or comment help wanted Extra attention is needed todo New task or assignment

Comments

@ATATC
Copy link
Member

ATATC commented Jan 18, 2024

This issue tests the Arduino Adapter.
SCRIPT "test/arduino.py"
@ATATC ATATC added code review Code review or comment todo New task or assignment labels Jan 18, 2024
@ATATC
Copy link
Member Author

ATATC commented Jan 18, 2024 •
edited
Loading

Bug found: The program is stuck waiting for a message.

@ATATC ATATC added bug Something isn't working help wanted Extra attention is needed labels Jan 18, 2024
@ATATC ATATC closed this as completed in 1a7d491 Jan 18, 2024
@ATATC
Copy link
Member Author

ATATC commented Jan 18, 2024

Bug found: Program shuts down prematurely.

@ATATC ATATC reopened this Jan 18, 2024
@ATATC
Copy link
Member Author

ATATC commented Jan 26, 2024 •
edited
Loading

Bug fixed.

if not msg or msg == b"disconnect":

This includes the case where msg is b"" and causes the connection to close prematurely.

@ATATC ATATC closed this as completed in e8d4d62 Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working code review Code review or comment help wanted Extra attention is needed todo New task or assignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ATATC