Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Prepare for kpack 0.1 #289

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Prepare for kpack 0.1 #289

merged 1 commit into from
Aug 28, 2020

Conversation

scothis
Copy link
Member

@scothis scothis commented Aug 28, 2020

Adds a new secret annotation kpack.io/docker to attach secrets to kpack
0.1 builds. Keeping existing annotations for back-compat.

Signed-off-by: Scott Andrews andrewssc@vmware.com

Adds a new secret annotation kpack.io/docker to attach secrets to kpack
0.1 builds. Keeping existing annotations for back-compat.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #289 into main will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   96.32%   96.47%   +0.14%     
==========================================
  Files         106      106              
  Lines        6341     5101    -1240     
==========================================
- Hits         6108     4921    -1187     
+ Misses        194      139      -55     
- Partials       39       41       +2     
Impacted Files Coverage Δ
pkg/binding/commands/image_create.go 95.12% <ø> (+0.89%) ⬆️
pkg/build/commands/credential_apply.go 98.53% <100.00%> (+0.12%) ⬆️
pkg/build/commands/credential_list.go 96.87% <100.00%> (+0.82%) ⬆️
pkg/k8s/client.go 93.54% <0.00%> (-0.40%) ⬇️
pkg/build/commands/container_create.go 98.59% <0.00%> (-0.26%) ⬇️
pkg/knative/commands/adapter_create.go 99.19% <0.00%> (-0.19%) ⬇️
pkg/cli/arguments.go 98.36% <0.00%> (-0.17%) ⬇️
pkg/riff/commands/completion.go 99.38% <0.00%> (-0.11%) ⬇️
pkg/cli/env.go 100.00% <0.00%> (ø)
pkg/cli/sort.go 100.00% <0.00%> (ø)
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1057c...7255cec. Read the comment docs.

@scothis scothis merged commit 6a24410 into projectriff:main Aug 28, 2020
@scothis scothis deleted the kpack-0.1 branch August 28, 2020 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant