-
Notifications
You must be signed in to change notification settings - Fork 29
Conversation
getting build failures with this in the log:
these are the errors:
|
Bizarre error (cause still unknown - something to do with an abstract test class). I think it's fixed now. Not sure what the abstract class does. |
yes, the build passes now thanks! |
|
||
} | ||
|
||
private Message<byte[]> payloadToBytes(Message<?> message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe extract from here down, along with the mapper, to a separate class
HeaderValue header = entry.getValue(); | ||
if (header.getValuesCount() > 0) { | ||
Object value; | ||
ProtocolStringList list = header.getValuesList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProtocolStringList can be a List here
private final ManagedChannel channel; | ||
private final MessageFunctionStub asyncStub; | ||
|
||
/** Construct client for accessing RouteGuide server at {@code host:port}. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment leftover from gRPC getting started guide I believe. will remove
Can't make this to work with the
The Tried with |
I have a rebased branch with this, with some additional polish that you may want to grab at https://github.com/ericbottard/java-function-invoker/tree/grpc |
@ericbottard I don't think that message function would work on master either. Did you say you had it working there (confused)? |
No, didn't say (or looked) that it worked on master either. This is prompted by the fact that, switching to this gRPC style, we now need to take care of propagating the |
It doesn't work on master then, as I suspected. We can discuss OOB. |
from OOB discussion today
|
Superseded by #26. |
The app now listens on port 10382 for a stream of riff
Messages, processing them using a
Function
fromthe URI passed in on startup.