Can't delete a file if it wasn't assigned to a user or a group

[bchhun]

I'm not sure whether this is a bug or a feature but here it goes.

Although a confirmation message is shown, it seems we can't delete a file if we didn't assigned it to a user or a group beforehand.

Steps to reproduce it

1. Upload a file
2. Don't assign it to any user or group
3. Try to delete it using the table interface in manage-file.php

Symptoms

There's no value attribute for the file's checkbox because the id comes from the files_relations table and we don't have any entry there...

And it stays that way during the whole deletion process until the confirmation message.

Possible solutions

1. Show a warning message mentionning we need to assign a file before we can delete it
2. Don't use the files_relations's file id and stick with the id from the files table

[andreas-stricker]

i also can not delete files as a system administrator or other user.
Is there a solution?

[bchhun]

@strigga yes. you need to assign the file you want to delete to a user or a group and then delete it.

[andreas-stricker]

Thank you. This works!
But why does it not assign automatically to the user who has uploaded the file?

So if i have 50 files and want to delete it i have to click on every single file - assign it to a user and after that i can delete it?

[bchhun]

My best guess is that you may upload files for other users and assign them whenever you want.

Yes for the mass deletion :)

[ignacionelson]

r582 includes this fix. Closing the issue now.

[bchhun]

+1

[ignacionelson]

Have you tried the latest version? r582

[riczito]

On r582 the problem still persists. As an admin, I cannot delete user files, whether they are assigned to users or not. As a user, I cannot delete my own files from my workspace. This is pretty essential functionality. Please help find a solution or workaround!

[tekopsinc]

Yes, the problem still persists. It does not delete the file(s) no matter what you do. Version r582 confirmed.

[semaphorism]

It looks like that $file_id in manage_files.php at line 537 is referencing the wrong ID (from tbl_files_relations rather than tbl_files as expected by the delete function). My fix was to change line 537 to read:

<td><input type="checkbox" name="files[]" value="<?php echo $row['id']; ?>" /></td>

I can't remember if that's all I did to fix this problem, but it's a start. Good luck.

[lenamtl]

Do you have an error message?

[ashes00]

semaphorism - I was able to make just the change that you mentioned, and it fixed my issue. I was not able to delete ANY file before. Now I can. Thank you!
,Ash

[tekopsinc]

We made the change (and it's manage-files.php, not manage_files.php) and it works great. Thank you so much!

[luisalmeidarealbase]

@semaphorism thank you for your solution. It worked! :D