Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right-click on a link (DefaultLinkWidget) ignores setLocked read-only mode of the model and allows to remove the link. #71

Closed
sompylasar opened this issue Aug 15, 2017 · 1 comment
Closed

Right-click on a link (DefaultLinkWidget) ignores setLocked read-only mode of the model and allows to remove the link. #71

sompylasar opened this issue Aug 15, 2017 · 1 comment

Comments

@sompylasar
Copy link

react-diagrams/src/defaults/DefaultLinkWidget.ts

Lines 85 to 88 in f36a8cf

onContextMenu: (event) => {
event.preventDefault();
this.props.link.remove();
},

@sompylasar sompylasar mentioned this issue Aug 15, 2017
Closed
sompylasar added a commit to sompylasar/react-diagrams that referenced this issue Aug 15, 2017
@sompylasar
Fixed a few cases where setLocked didn't lock.
b4e2b56 
- Fixes projectstorm#71
- Fixes projectstorm#73
@sompylasar sompylasar mentioned this issue Aug 15, 2017
Closed
dylanvorster added a commit that referenced this issue Sep 2, 2017
@dylanvorster
Fixed #71
e600da1
@dylanvorster
Copy link
Member

Fixed in 2.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sompylasar @dylanvorster