New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart routing #161

Merged

dylanvorster merged 8 commits into projectstorm:links_refactor from klauspaiva:smart-routing

Feb 18, 2018

Contributor

klauspaiva commented Feb 14, 2018

Checklist

The code has been run through pretty yarn run pretty
The tests pass on CircleCI
You have referenced the issue(s) or other PR(s) this fixes/relates-to
The PR Template has been filled out (see below)
Had a beer because you are awesome

What?

Introduces smart routing to the library.

Why?

For some use cases an automatically generated orthogonal representation of the links results in a better visualisation.
It also improves the overall aesthetic as links find their way around other nodes.

How?

Basically a combination of PathFinding.js and Paths.js, with extra bits of magic to put everything to work together. :)

Demos?

Yes, many!
There is a new storybook entry + demos for enabling it by default to confirm it works well with all other setups already handled by the library.

Feel-Good "programming lol" image:

source: https://www.improgrammer.net/best-programming-jokes/

Klaus Paiva added 8 commits

February 12, 2018 16:58


          Smart routing: flattening changes

2fdf944


          Allowing new connections to be created

4ea968d


          Doing smart routing when conditions are met

afa34ae


          Correct calculation when nodes are placed at the very edge of the canvas

088230d


          Code re-factoring

724b1d3


          Tests for logic in the smart routing class

b243d66


          Also testing the new story

183390a


          Updating docs

f811f12

Member

dylanvorster commented Feb 14, 2018

My head just exploded

Member

dylanvorster commented Feb 18, 2018

busy merging this into the 5.0.0 branch x__x

dylanvorster changed the base branch from master to links_refactor

February 18, 2018 18:11

dylanvorster merged commit f811f12 into projectstorm:links_refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment