Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcode for PointModel in DefaultLinkWidget.tsx #939

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Remove hardcode for PointModel in DefaultLinkWidget.tsx #939

merged 1 commit into from
Jan 24, 2023

Conversation

ToTheHit
Copy link
Contributor

@ToTheHit ToTheHit commented May 4, 2022 •
edited

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer/coffee because you are awesome

What?

Remove hardcode for PointModel in DefaultLinkWidget.tsx (☞ﾟヮﾟ)☞
#938

Why?

  1. Hardcode is bad
  2. In current version of DefaultLinkWidget users can't use custom Points

How?

Simply using the already existing LinkModel method ༼ つ ◕_◕ ༽つ

Feel good image:

image

@ToTheHit ToTheHit force-pushed the update_default_link_widget branch from 7e6b8f6 to b106bb9 Compare May 4, 2022 15:04
@ToTheHit ToTheHit force-pushed the update_default_link_widget branch from b106bb9 to 77011af Compare May 4, 2022 15:07
@dylanvorster
Copy link
Member

click noice

@dylanvorster
Copy link
Member

ill try get this merged soon after some testing on my side as well

@dylanvorster dylanvorster changed the base branch from master to features January 24, 2023 23:56
@dylanvorster dylanvorster merged commit 17bb78b into projectstorm:features Jan 24, 2023
@dylanvorster dylanvorster mentioned this pull request Jan 25, 2023
Merged
6 tasks
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ToTheHit @dylanvorster