-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local Git user information when running Commodore locally #63
Labels
enhancement
New feature or request
Projects
Comments
daiboruta
pushed a commit
to daiboruta/commodore
that referenced
this issue
Jul 1, 2020
5 tasks
daiboruta
pushed a commit
to daiboruta/commodore
that referenced
this issue
Jul 10, 2020
simu
pushed a commit
to daiboruta/commodore
that referenced
this issue
Jul 20, 2020
This commit introduces new arguments for `commodore catalog compile` for overriding local Git user information when pushing commits to a cluster catalog. By default Commodore will use the local Git user information for catalog commits. To improve compatibility with existing Git configurations, the arguments are named `--git-author-name` and `--git-author-email` to pick up the familiar `GIT_AUTHOR_NAME` and `GIT_AUTHOR_EMAIL` environment variables without any further configuration. Please note: Commodore does not allow you to override commit author and committer separately, and will use the provided author name and email, if any, as both commit author and committer. The commit also updates docker-compose.yaml to map `~/.gitconfig` into the container to propagate the global Git config into the container. This simplifies reusing the Git author configuration on the host system when running Commodore locally using docker-compose. Resolves projectsyn#63
daiboruta
pushed a commit
to daiboruta/commodore
that referenced
this issue
Jul 31, 2020
daiboruta
pushed a commit
to daiboruta/commodore
that referenced
this issue
Jul 31, 2020
daiboruta
pushed a commit
to daiboruta/commodore
that referenced
this issue
Aug 6, 2020
daiboruta
pushed a commit
to daiboruta/commodore
that referenced
this issue
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now Commodore always configures the Git committer and author to be
Commodore <commodore@vshn.net>
.The audit trail would be much improved if Commodore uses the local Git user information when running locally.
Ideally, Commodore will use the local Git user information by default, and expose configuration options to override this behavior.
The text was updated successfully, but these errors were encountered: