Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local Git user information when running Commodore locally #63

Closed
simu opened this issue Mar 13, 2020 · 0 comments
Closed

Use local Git user information when running Commodore locally #63

simu opened this issue Mar 13, 2020 · 0 comments
Labels
enhancement New feature or request
Projects
Project Syn v0.2.0

Comments

@simu
Copy link
Member

simu commented Mar 13, 2020

Right now Commodore always configures the Git committer and author to be Commodore <commodore@vshn.net>.

The audit trail would be much improved if Commodore uses the local Git user information when running locally.

Ideally, Commodore will use the local Git user information by default, and expose configuration options to override this behavior.
@simu simu added the enhancement New feature or request label Mar 13, 2020
@simu simu added this to To do in Project Syn v0.2.0 via automation Mar 13, 2020
daiboruta pushed a commit to daiboruta/commodore that referenced this issue Jul 1, 2020
First commit for issue projectsyn#63
fecb900
@daiboruta daiboruta mentioned this issue Jul 9, 2020
Merged
5 tasks
daiboruta pushed a commit to daiboruta/commodore that referenced this issue Jul 10, 2020
First commit for issue projectsyn#63
6fb6308
simu pushed a commit to daiboruta/commodore that referenced this issue Jul 20, 2020
@simu
Allow overriding Git user info for catalog commits
66b6105 
This commit introduces new arguments for `commodore catalog compile` for
overriding local Git user information when pushing commits to a cluster
catalog.

By default Commodore will use the local Git user information for catalog
commits.
To improve compatibility with existing Git configurations, the arguments
are named `--git-author-name` and `--git-author-email` to pick up the
familiar `GIT_AUTHOR_NAME` and `GIT_AUTHOR_EMAIL` environment variables
without any further configuration.

Please note: Commodore does not allow you to override commit author and
committer separately, and will use the provided author name and email,
if any, as both commit author and committer.

The commit also updates docker-compose.yaml to map `~/.gitconfig` into
the container to propagate the global Git config into the container.
This simplifies reusing the Git author configuration on the host system
when running Commodore locally using docker-compose.

Resolves projectsyn#63
@simu simu closed this as completed in 10db30e Jul 21, 2020
Project Syn v0.2.0 automation moved this from To do to Done Jul 21, 2020
daiboruta pushed a commit to daiboruta/commodore that referenced this issue Jul 31, 2020
First commit for issue projectsyn#63
abc39c7
daiboruta pushed a commit to daiboruta/commodore that referenced this issue Jul 31, 2020
First commit for issue projectsyn#63
02f8d31
daiboruta pushed a commit to daiboruta/commodore that referenced this issue Aug 6, 2020
First commit for issue projectsyn#63
dc27eeb
daiboruta pushed a commit to daiboruta/commodore that referenced this issue Aug 6, 2020
First commit for issue projectsyn#63
2ab539e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Project Syn v0.2.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simu