Add component parameter for configuring additional Prometheus rules #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes use of the new openshift4-monitoring library function introduced in appuio/component-openshift4-monitoring#162
simu
commented
Jun 30, 2023
Comment on lines
+97
to
+99
| std.trace( | ||
| 'Prometheus object helper library not available on non-OCP4, additional rules may be configured incorrectly', | ||
| { |
There was a problem hiding this comment.
This is ugly, but necessary since the component nominally supports non-OCP4
DebakelOrakel
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the new openshift4-monitoring library function introduced in appuio/component-openshift4-monitoring#162
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.