Introduce style guide #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corvus-ch
force-pushed
the
style
branch
5 times, most recently
from
de8a01a
to
82e4c0d
Compare
srueg
approved these changes
Sep 7, 2020
srueg
approved these changes
Sep 7, 2020
tobru
requested changes
Sep 7, 2020
corvus-ch
commented
Sep 7, 2020
Good point. Will do. |
akosma
approved these changes
Sep 7, 2020
tobru
reviewed
Sep 7, 2020
tobru
approved these changes
Sep 7, 2020
simu
requested changes
Sep 7, 2020
srueg
suggested changes
Sep 8, 2020
Kidswiss
reviewed
Sep 8, 2020
simu
approved these changes
Sep 8, 2020
Co-authored-by: Simon Rüegg <simon.ruegg@vshn.ch>
Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Use function and template function instead of method and classes.
Co-authored-by: Simon Rüegg <simon.ruegg@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
1 task
simu
added a commit
to projectsyn/commodore
that referenced
this pull request
Sep 18, 2020
We decided in projectsyn/documentation#88 that we want to pad arrays in Jsonnet. This commit adds the `--pad-arrays` argument to the default jsonnetfmt arguments in the component template Makefile.
simu
added a commit
to projectsyn/commodore
that referenced
this pull request
Sep 18, 2020
We decided in projectsyn/documentation#88 that we want to pad arrays in Jsonnet. This commit adds the `--pad-arrays` argument to the default jsonnetfmt arguments in the component template Makefile.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the style guide as it was discussed in #40.
Checklist