Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set the ID when creating Clusters and Tenants #123

Merged
merged 5 commits into from
Feb 19, 2021
Merged

Ability to set the ID when creating Clusters and Tenants #123

merged 5 commits into from
Feb 19, 2021

Conversation

corvus-ch
Copy link
Contributor

@corvus-ch corvus-ch commented Feb 12, 2021 •
edited
Loading

Implementes #98.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

@corvus-ch corvus-ch self-assigned this Feb 12, 2021
@corvus-ch corvus-ch changed the title Allow Setting ID in API Ability to set the ID when creating Clusters and Tenants Feb 15, 2021
@corvus-ch
Update open API spec
599165c 
Allow ID when creating clusters and tenants.
@corvus-ch corvus-ch marked this pull request as ready for review February 15, 2021 14:06
ccremer
ccremer reviewed Feb 15, 2021
View reviewed changes
pkg/service/cluster_test.go Outdated Show resolved Hide resolved
pkg/service/tenant_test.go Outdated Show resolved Hide resolved
pkg/service/tenant.go Outdated Show resolved Hide resolved
@srueg
Copy link
Contributor

srueg commented Feb 17, 2021

Please test this implementation on the SYNfra cluster in the lieutenant-dev namespace before merging.
You can either build & deploy a test image or run the operator locally against the cluster.

@corvus-ch corvus-ch merged commit 415b5fd into master Feb 19, 2021
@corvus-ch corvus-ch deleted the allow_id branch February 19, 2021 12:37
@ccremer ccremer linked an issue Feb 26, 2021 that may be closed by this pull request
Allow Setting ID in API #98
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srueg srueg srueg approved these changes

@ccremer ccremer ccremer approved these changes

Assignees

@corvus-ch corvus-ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Setting ID in API
3 participants
@corvus-ch @srueg @ccremer