Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to sort cluster list by id, tenant, or displayName #200

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Add option to sort cluster list by id, tenant, or displayName #200

merged 3 commits into from
Oct 26, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Oct 25, 2022

We want to be able to sort the order of clusters for commodore: projectsyn/commodore#596

Instead of doing this in commodore itself we implemented it in the API, which I think is the better approach

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues.

@glrf glrf marked this pull request as ready for review October 26, 2022 08:33
@glrf glrf self-assigned this Oct 26, 2022
@glrf glrf added the enhancement New feature or request label Oct 26, 2022
@glrf glrf requested a review from simu October 26, 2022 08:33
@glrf glrf merged commit 550c9ff into master Oct 26, 2022
@glrf glrf deleted the feat/sort-clusters branch October 26, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees

@glrf glrf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glrf @simu