Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nokogiri in case of security vulnerability #159

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

dczulada
Copy link
Contributor

Pull requests into cqm-parsers require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov-commenter
Copy link

Codecov Report

Merging #159 (149110c) into master (fd4d124) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   82.40%   82.42%   +0.01%     
==========================================
  Files          69       69              
  Lines        4320     4318       -2     
==========================================
- Hits         3560     3559       -1     
+ Misses        760      759       -1     
Impacted Files Coverage Δ
lib/hqmf-parser/2.0/population_criteria.rb 93.44% <100.00%> (ø)
...rser/cql/document_helpers/doc_population_helper.rb 98.86% <100.00%> (ø)
lib/hqmf-parser/2.0/document.rb 90.76% <0.00%> (-0.77%) ⬇️
lib/util/vsac_api.rb 98.07% <0.00%> (ø)
lib/hqmf-parser/2.0/types.rb 83.82% <0.00%> (ø)
lib/hqmf-parser/1.0/attribute.rb 100.00% <0.00%> (ø)
lib/hqmf-parser/1.0/data_criteria.rb 97.91% <0.00%> (ø)
lib/hqmf-parser/2.0/data_criteria.rb 81.69% <0.00%> (ø)
lib/measure-loader/mat_measure_files.rb 95.34% <0.00%> (ø)
lib/hqmf-parser/2.0/field_value_helper.rb 88.79% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ca79b...149110c. Read the comment docs.

@dczulada dczulada requested a review from lmd59 September 29, 2021 12:17
@lmd59 lmd59 self-assigned this Sep 29, 2021
@lmd59 lmd59 merged commit b42e293 into master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants