Merge d80f3e2 into 62ec70a

projectwallace · Jul 2, 2019 · e7f4af2 · e7f4af2
2 parents 62ec70a + d80f3e2
commit e7f4af2
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 18 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -68,7 +68,7 @@
     "is-vendor-prefixed": "^3.3.0",
     "path": "^0.12.7",
     "postcss": "^7.0.17",
-    "postcss-values-parser": "^3.0.4",
+    "postcss-values-parser": "^3.0.5",
     "specificity": "^0.4.1",
     "split-lines": "^2.0.0",
     "string-natural-compare": "^2.0.3",

diff --git a/src/analyzer/values/colors.js b/src/analyzer/values/colors.js
@@ -7,7 +7,12 @@ const uniquer = require('../../utils/uniquer')
 function extractColorsFromDeclaration(declaration) {
   const colors = []
 
-  // Temporary try-catch until https://github.com/shellscape/postcss-values-parser/issues/76 is fixed
+  // Try-catch to ignore values that cannot be parsed with postcss-values-parser
+  // Examples:
+  // - Base64-encoded images
+  // - startColorstr=\'#5243AA\', endColorstr=\'#0079bf\', GradientType=1
+  // - opacity=50
+  // - 1.5deg
   try {
     parse(declaration.value, {loose: true}).walk(node => {
       if (node.isColor) {