Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#59 fix scrollbar in the panel #95

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

Yaricherchi7
Copy link
Contributor

@Yaricherchi7 Yaricherchi7 commented Jan 26, 2024

Description

What type of PR is this? (check all applicable)

  • πŸ’‘ Feature
  • [ x] πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

https://www.loom.com/share/6397149750314ae3a2655c89c3de3f11?sid=4a2c52aa-2fe9-4364-888e-3460c5b1f37d

Steps to QA

Added to documentation?

  • πŸ“œ README.md
  • [ x] πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

vercel bot commented Jan 26, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @meglerhagen on Vercel.

@meglerhagen first needs to authorize it.

@Codehagen
Copy link
Member

This is working! Could you do this to the other pages also @Yaricherchi7? 🀩

Have not tried it with all browsers, but working on Chrome.

Copy link
Member

@Codehagen Codehagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could we do it for all the dashboards besides /dashboard page.tsx? (This is not using it)

@Yaricherchi7
Copy link
Contributor Author

we could use it on all pages, it works pretty well! if you open another task for me I could extend it across all pages

@Codehagen
Copy link
Member

Perfect - Lets merge this and work on the other pages in another issue.

Copy link
Member

@Codehagen Codehagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and working on Chrome. Merging.

@Codehagen Codehagen merged commit dc07cac into projectx-codehagen:main Jan 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants