Skip to content

Commit

Permalink
fix: gitattributes not recognizing projen files as generated (#856)
Browse files Browse the repository at this point in the history
Files in `/.projen/` are not currently being recognized as generated in GitHub's UI. The reason is that according to the [gitattributes docs](https://git-scm.com/docs/gitattributes):

> patterns that match a directory do not recursively match paths inside that directory (so using the trailing-slash `path/` syntax is pointless in an attributes file; use `path/**` instead)
  • Loading branch information
Chriscbr committed Jun 6, 2021
1 parent 1c32a60 commit 30d3c3b
Show file tree
Hide file tree
Showing 13 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .gitattributes

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/__tests__/__snapshots__/cli.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/__tests__/__snapshots__/integ.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/__tests__/java/__snapshots__/java-project.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/__tests__/java/__snapshots__/projenrc.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/__tests__/python/__snapshots__/projenrc.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/__tests__/release/__snapshots__/release.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/__tests__/web/__snapshots__/react-project.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/github/github.ts
Expand Up @@ -33,7 +33,7 @@ export class GitHub extends Component {
this.gitattributes = new GitattributesFile(project);

// Contents of the .projen/ directory are generated by projen
this.annotateGenerated('/.projen/');
this.annotateGenerated('/.projen/**');
// The .gitattributes file itself is generated
this.annotateGenerated(`/${this.gitattributes.path}`);

Expand Down

0 comments on commit 30d3c3b

Please sign in to comment.